Debugging CI System Test Issues

[lomky]

(Not For Merging)

[lomky]

Working starting based on this comment, going to investigate if we have the previously-reliable-now-race-condition issue.

[lomky]

rails/rails#48973 suggests not to include the webdriver gem explicitly

[lomky]

DevLog CapyIssues

Conclusion

No progress made on resolving this session.

Noop commit baseline

System tests fail - CI

UpdatePatientInfoTest::clicking around#test_0001_should let you click back to abortion information:
Selenium::WebDriver::Error::SessionNotCreatedError: session not created: probably user data directory is already in use, please specify a unique value for --user-data-dir argument, or don't use --user-data-dir

Pull #3376 changes

System tests fail differently - CI

rails/rails-48973 suggests not to include the webdriver gem explicitly

Remove webdriver gem

Back to baseline - CI

UpdatePatientInfoTest::clicking around#test_0001_should let you click back to abortion information:
Selenium::WebDriver::Error::SessionNotCreatedError: session not created: probably user data directory is already in use, please specify a unique value for --user-data-dir argument, or don't use --user-data-dir

Add a user-data-dir

No change, still complains. - CI. Reverting

[wwahammy]

Hey all, we stumbled on this internally and so far, this fix seems to a solid fix https://github.com/alphagov/forms-admin/blob/5ea98767d765a396ed06cf2cba8f9afb1b10fc0e/spec/support/selenium_error_patch.rb nevermind, I realize you have a different bug than we did.

[lomky]

@wwahammy appreciate the thought, who knows how many issues are behind the first one!