Skip to content

Conversation

@illwieckz
Copy link
Member

Add the INSTALL_STATIC_LIBS option to allow the installation (or not) of static libraries.

Installing static libraries is useful in the context of a distribution package of libcrn itself.

But for projects linking against libcrn for there own package, it is useless to distribute it.

This has been motivated by me using libcrn to add CRN support in the XQF server browser:

@illwieckz
Copy link
Member Author

This looks obvious enough.

@illwieckz illwieckz merged commit 54b8c94 into master Jul 20, 2025
15 checks passed
@illwieckz illwieckz deleted the illwieckz/no-install-libs branch July 20, 2025 16:47
@slipher
Copy link
Member

slipher commented Jul 20, 2025

If you're including the crunch cmake into a super-project wouldn't you want to name it like CRUNCH_xxx? Naming it just INSTALL_STATIC_LIBS is confusing because one would assume it's for the top-level project.

@illwieckz
Copy link
Member Author

Or INSTALL_STATIC_LIBCRN since we already have BUILD_STATIC_LIBCRN.

@illwieckz
Copy link
Member Author

Now renamed as INSTALL_STATIC_LIBCRN.

@illwieckz
Copy link
Member Author

Since it's OFF by default we can rename it as we like anyway, projects including the Crunch CMakeLists.txt file and not wanting to install the static lib just have nothing to set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants