-
Notifications
You must be signed in to change notification settings - Fork 319
Cleanup classpath for modules with dependency on Groovy and Spock #10069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| addTestSuiteForDir('latestDepTest', 'test') | ||
|
|
||
| dependencies { | ||
| testImplementation(libs.javaparser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering -- do you know why this previously didn't need to be included?
I see that you also included libs.javaparser with your changes in gradle/libs.versions.toml, but if I understand correctly, this library wasn't a part of groovy-all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it is from groovy-all:
./gradlew :dd-java-agent:instrumentation:java:java-lang:java-lang-15.0:dependencies
Part of the tree:
org.codehaus.groovy:groovy-all:3.0.24
| +--- org.codehaus.groovy:groovy-groovydoc:3.0.24
| | +--- org.codehaus.groovy:groovy:3.0.24
| | \--- com.github.javaparser:javaparser-core:3.25.6
And there usage in tests:
import com.github.javaparser.utils.StringEscapeUtils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR make that obvious, that we NEVER used groovydoc, but its transitive dependency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh cool okay, thanks!
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~571d9644e7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080064
Total [baseline] (8.748 s) : 0, 8748132
Agent [candidate] (1.083 s) : 0, 1082833
Total [candidate] (8.755 s) : 0, 8755453
section iast
Agent [baseline] (1.222 s) : 0, 1222379
Total [baseline] (9.49 s) : 0, 9490157
Agent [candidate] (1.224 s) : 0, 1224178
Total [candidate] (9.446 s) : 0, 9446261
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~571d9644e7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (648.676 ms) : 0, 648676
BytebuddyAgent [candidate] (650.23 ms) : 0, 650230
GlobalTracer [baseline] (281.411 ms) : 0, 281411
GlobalTracer [candidate] (282.633 ms) : 0, 282633
AppSec [baseline] (32.44 ms) : 0, 32440
AppSec [candidate] (32.588 ms) : 0, 32588
Debugger [baseline] (67.364 ms) : 0, 67364
Debugger [candidate] (67.216 ms) : 0, 67216
Remote Config [baseline] (657.134 µs) : 0, 657
Remote Config [candidate] (651.847 µs) : 0, 652
Telemetry [baseline] (8.992 ms) : 0, 8992
Telemetry [candidate] (8.94 ms) : 0, 8940
Flare Poller [baseline] (3.72 ms) : 0, 3720
Flare Poller [candidate] (3.752 ms) : 0, 3752
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (788.736 ms) : 0, 788736
BytebuddyAgent [candidate] (791.7 ms) : 0, 791700
GlobalTracer [baseline] (255.596 ms) : 0, 255596
GlobalTracer [candidate] (256.004 ms) : 0, 256004
AppSec [baseline] (35.731 ms) : 0, 35731
AppSec [candidate] (35.642 ms) : 0, 35642
Debugger [baseline] (65.982 ms) : 0, 65982
Debugger [candidate] (64.773 ms) : 0, 64773
Remote Config [baseline] (564.272 µs) : 0, 564
Remote Config [candidate] (554.618 µs) : 0, 555
Telemetry [baseline] (8.626 ms) : 0, 8626
Telemetry [candidate] (8.4 ms) : 0, 8400
Flare Poller [baseline] (3.656 ms) : 0, 3656
Flare Poller [candidate] (3.515 ms) : 0, 3515
IAST [baseline] (26.775 ms) : 0, 26775
IAST [candidate] (26.924 ms) : 0, 26924
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~571d9644e7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086433
Total [baseline] (10.956 s) : 0, 10956036
Agent [candidate] (1.081 s) : 0, 1080504
Total [candidate] (10.849 s) : 0, 10849013
section appsec
Agent [baseline] (1.262 s) : 0, 1262462
Total [baseline] (11.189 s) : 0, 11189226
Agent [candidate] (1.272 s) : 0, 1271607
Total [candidate] (11.167 s) : 0, 11166635
section iast
Agent [baseline] (1.231 s) : 0, 1231244
Total [baseline] (11.191 s) : 0, 11191257
Agent [candidate] (1.225 s) : 0, 1224559
Total [candidate] (11.139 s) : 0, 11138535
section profiling
Agent [baseline] (1.21 s) : 0, 1209569
Total [baseline] (11.039 s) : 0, 11039397
Agent [candidate] (1.205 s) : 0, 1204797
Total [candidate] (10.945 s) : 0, 10944610
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~571d9644e7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (652.478 ms) : 0, 652478
BytebuddyAgent [candidate] (648.081 ms) : 0, 648081
GlobalTracer [baseline] (282.833 ms) : 0, 282833
GlobalTracer [candidate] (281.71 ms) : 0, 281710
AppSec [baseline] (32.571 ms) : 0, 32571
AppSec [candidate] (32.263 ms) : 0, 32263
Debugger [baseline] (68.353 ms) : 0, 68353
Debugger [candidate] (68.372 ms) : 0, 68372
Remote Config [baseline] (674.615 µs) : 0, 675
Remote Config [candidate] (639.124 µs) : 0, 639
Telemetry [baseline] (8.912 ms) : 0, 8912
Telemetry [candidate] (9.017 ms) : 0, 9017
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.724 ms) : 0, 3724
section appsec
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (687.945 ms) : 0, 687945
BytebuddyAgent [candidate] (694.819 ms) : 0, 694819
GlobalTracer [baseline] (258.565 ms) : 0, 258565
GlobalTracer [candidate] (259.827 ms) : 0, 259827
AppSec [baseline] (174.113 ms) : 0, 174113
AppSec [candidate] (174.792 ms) : 0, 174792
Debugger [baseline] (67.056 ms) : 0, 67056
Debugger [candidate] (67.04 ms) : 0, 67040
Remote Config [baseline] (731.811 µs) : 0, 732
Remote Config [candidate] (725.85 µs) : 0, 726
Telemetry [baseline] (8.945 ms) : 0, 8945
Telemetry [candidate] (8.989 ms) : 0, 8989
Flare Poller [baseline] (3.852 ms) : 0, 3852
Flare Poller [candidate] (3.791 ms) : 0, 3791
IAST [baseline] (24.45 ms) : 0, 24450
IAST [candidate] (24.595 ms) : 0, 24595
section iast
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (796.6 ms) : 0, 796600
BytebuddyAgent [candidate] (791.133 ms) : 0, 791133
GlobalTracer [baseline] (256.874 ms) : 0, 256874
GlobalTracer [candidate] (255.664 ms) : 0, 255664
AppSec [baseline] (35.647 ms) : 0, 35647
AppSec [candidate] (35.805 ms) : 0, 35805
Debugger [baseline] (65.665 ms) : 0, 65665
Debugger [candidate] (65.902 ms) : 0, 65902
Remote Config [baseline] (541.975 µs) : 0, 542
Remote Config [candidate] (539.645 µs) : 0, 540
Telemetry [baseline] (8.408 ms) : 0, 8408
Telemetry [candidate] (8.453 ms) : 0, 8453
Flare Poller [baseline] (3.499 ms) : 0, 3499
Flare Poller [candidate] (3.519 ms) : 0, 3519
IAST [baseline] (27.189 ms) : 0, 27189
IAST [candidate] (26.876 ms) : 0, 26876
section profiling
ProfilingAgent [baseline] (97.691 ms) : 0, 97691
ProfilingAgent [candidate] (97.59 ms) : 0, 97590
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (704.683 ms) : 0, 704683
BytebuddyAgent [candidate] (701.96 ms) : 0, 701960
GlobalTracer [baseline] (221.665 ms) : 0, 221665
GlobalTracer [candidate] (220.717 ms) : 0, 220717
AppSec [baseline] (32.675 ms) : 0, 32675
AppSec [candidate] (32.278 ms) : 0, 32278
Debugger [baseline] (68.475 ms) : 0, 68475
Debugger [candidate] (68.069 ms) : 0, 68069
Remote Config [baseline] (635.836 µs) : 0, 636
Remote Config [candidate] (623.419 µs) : 0, 623
Telemetry [baseline] (8.921 ms) : 0, 8921
Telemetry [candidate] (9.019 ms) : 0, 9019
Flare Poller [baseline] (3.753 ms) : 0, 3753
Flare Poller [candidate] (3.753 ms) : 0, 3753
Profiling [baseline] (98.272 ms) : 0, 98272
Profiling [candidate] (98.183 ms) : 0, 98183
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~571d9644e7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section baseline
no_agent (1.178 ms) : 1166, 1189
. : milestone, 1178,
iast (3.248 ms) : 3205, 3291
. : milestone, 3248,
iast_FULL (5.951 ms) : 5891, 6011
. : milestone, 5951,
iast_GLOBAL (3.635 ms) : 3582, 3688
. : milestone, 3635,
profiling (1.898 ms) : 1883, 1913
. : milestone, 1898,
tracing (1.782 ms) : 1767, 1797
. : milestone, 1782,
section candidate
no_agent (1.216 ms) : 1204, 1229
. : milestone, 1216,
iast (3.417 ms) : 3370, 3463
. : milestone, 3417,
iast_FULL (5.648 ms) : 5592, 5704
. : milestone, 5648,
iast_GLOBAL (3.63 ms) : 3577, 3684
. : milestone, 3630,
profiling (1.905 ms) : 1889, 1922
. : milestone, 1905,
tracing (1.793 ms) : 1777, 1809
. : milestone, 1793,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~571d9644e7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section baseline
no_agent (18.31 ms) : 18121, 18499
. : milestone, 18310,
appsec (18.732 ms) : 18541, 18923
. : milestone, 18732,
code_origins (18.039 ms) : 17857, 18221
. : milestone, 18039,
iast (17.957 ms) : 17775, 18138
. : milestone, 17957,
profiling (18.388 ms) : 18206, 18571
. : milestone, 18388,
tracing (17.647 ms) : 17472, 17821
. : milestone, 17647,
section candidate
no_agent (19.256 ms) : 19058, 19454
. : milestone, 19256,
appsec (18.592 ms) : 18404, 18780
. : milestone, 18592,
code_origins (17.887 ms) : 17708, 18065
. : milestone, 17887,
iast (17.752 ms) : 17577, 17927
. : milestone, 17752,
profiling (18.657 ms) : 18469, 18844
. : milestone, 18657,
tracing (17.793 ms) : 17616, 17970
. : milestone, 17793,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~571d9644e7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (3.742 ms) : 3521, 3963
. : milestone, 3742,
iast (2.209 ms) : 2145, 2274
. : milestone, 2209,
iast_GLOBAL (2.263 ms) : 2197, 2328
. : milestone, 2263,
profiling (2.482 ms) : 2328, 2635
. : milestone, 2482,
tracing (2.04 ms) : 1989, 2090
. : milestone, 2040,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.683 ms) : 3466, 3900
. : milestone, 3683,
iast (2.214 ms) : 2150, 2279
. : milestone, 2214,
iast_GLOBAL (2.256 ms) : 2192, 2321
. : milestone, 2256,
profiling (2.092 ms) : 2038, 2146
. : milestone, 2092,
tracing (2.052 ms) : 2001, 2102
. : milestone, 2052,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~571d9644e7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
dateFormat X
axisFormat %s
section baseline
no_agent (15.438 s) : 15438000, 15438000
. : milestone, 15438000,
appsec (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
iast (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
iast_GLOBAL (17.852 s) : 17852000, 17852000
. : milestone, 17852000,
profiling (14.663 s) : 14663000, 14663000
. : milestone, 14663000,
tracing (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
section candidate
no_agent (15.468 s) : 15468000, 15468000
. : milestone, 15468000,
appsec (14.577 s) : 14577000, 14577000
. : milestone, 14577000,
iast (18.124 s) : 18124000, 18124000
. : milestone, 18124000,
iast_GLOBAL (18.098 s) : 18098000, 18098000
. : milestone, 18098000,
profiling (14.537 s) : 14537000, 14537000
. : milestone, 14537000,
tracing (14.612 s) : 14612000, 14612000
. : milestone, 14612000,
|
What Does This Do
groovy-alldependency with individualgroovy-*modules.GroovyandSpockdependencies so they are used only within the test scope.Motivation
Using the bundled
groovy-allartifact introduces a large set of transitive dependencies into the classpath, many of which are unnecessary. Splitting it into specificgroovy-*modules helps reduce classpath footprint and improves build hygiene.Additionally, several modules previously declared
GroovyandSpockasapidependencies, even when they were only required for testing. This PR corrects that by limiting their usage to the appropriate scope.Additional Notes
Approximately 95% of modules already use
GroovyandSpockviatestImplementation. The remaining modules have been adjusted manually to prevent unneeded classpath pollution.