-
Notifications
You must be signed in to change notification settings - Fork 470
chore(ci_visibility): add telemetry to the new plugin, part 3 #15570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci_visibility): add telemetry to the new plugin, part 3 #15570
Conversation
|
|
1bf4547 to
811f027
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 252 ± 5 ms. The average import time from base is: 250 ± 3 ms. The import time difference between this PR and base is: 2.3 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate vitor-de-araujo/SDTEST-2663/telemetry-3 (6c9db4d) with baseline main (ddb3870) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.109µs (SLO: <10.000µs 📉 -48.9%) vs baseline: 📈 +21.4% Memory: ✅ 38.555MB (SLO: <41.000MB -6.0%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 1.082µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.4% Memory: ✅ 38.574MB (SLO: <41.000MB -5.9%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.090µs (SLO: <10.000µs 📉 -39.1%) vs baseline: +0.6% Memory: ✅ 38.614MB (SLO: <41.000MB -5.8%) vs baseline: +5.4% ✅ ospathjoin_noaspectTime: ✅ 2.298µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.2% Memory: ✅ 38.653MB (SLO: <41.000MB -5.7%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.454µs (SLO: <10.000µs 📉 -65.5%) vs baseline: -1.2% Memory: ✅ 38.535MB (SLO: <41.000MB -6.0%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.573µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +1.4% Memory: ✅ 38.673MB (SLO: <41.000MB -5.7%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.816µs (SLO: <10.000µs 📉 -51.8%) vs baseline: -0.5% Memory: ✅ 38.574MB (SLO: <41.000MB -5.9%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 1.594µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.2% Memory: ✅ 38.594MB (SLO: <41.000MB -5.9%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.634µs (SLO: <10.000µs 📉 -63.7%) vs baseline: -1.6% Memory: ✅ 38.516MB (SLO: <41.000MB -6.1%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.694µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.3% Memory: ✅ 38.574MB (SLO: <41.000MB -5.9%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.554µs (SLO: <10.000µs 📉 -54.5%) vs baseline: +0.3% Memory: ✅ 38.535MB (SLO: <41.000MB -6.0%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 1.375µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.9% Memory: ✅ 38.555MB (SLO: <41.000MB -6.0%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.350µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +16.8% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 200.517µs (SLO: <220.000µs -8.9%) vs baseline: +0.5% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.183µs (SLO: <20.000µs 📉 -84.1%) vs baseline: -0.1% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.371µs (SLO: <230.000µs -7.2%) vs baseline: -0.3% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.152µs (SLO: <20.000µs 📉 -89.2%) vs baseline: ~same Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.851µs (SLO: <150.000µs -8.8%) vs baseline: -0.8% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ 1-rate-metric-1-timesTime: ✅ 3.009µs (SLO: <20.000µs 📉 -85.0%) vs baseline: ~same Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 212.432µs (SLO: <250.000µs 📉 -15.0%) vs baseline: +0.2% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.189ms (SLO: <22.000ms -8.2%) vs baseline: +1.4% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +5.1% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.225ms (SLO: <2.550ms 📉 -12.8%) vs baseline: -1.1% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.399ms (SLO: <1.550ms -9.8%) vs baseline: -0.7% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.198ms (SLO: <2.550ms 📉 -13.8%) vs baseline: +0.3% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.499µs (SLO: <20.000µs 📉 -77.5%) vs baseline: ~same Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 174.406µs (SLO: <250.000µs 📉 -30.2%) vs baseline: -0.4% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.179ms (SLO: <2.500ms 📉 -12.8%) vs baseline: +0.1% Memory: ✅ 35.960MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.8% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Add telemetry for parsing errors in API requests, as well as git packfile upload events.
This PR also introduces tests for the API client and the various error conditions.
Testing
Unit tests, manual testing.
Risks
None.
Additional Notes
None.