fix: Prevent characterCountElement prop from being set on DOM elements #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieyan
requested review from
a team and
Bloomca
and removed request for
a team
frankieyan
added
the
👀 Show PR
Bloomca
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This fixes the warnings thrown in development mode by the
SelectFieldandTextAreacomments, where thecharacterCountElementprop was being passed to a DOM element:In our test suite, we still have two instances of this error for the
exceptionallySetClassNameprop, but these were intentionally added in the tests, and are not supported props in the Banner and Badge components.PR Checklist