Skip to content

fix: Make ntfy access token optional (#2938) #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: canary
Choose a base branch
from
Open

fix: Make ntfy access token optional (#2938) #2946

wants to merge 3 commits into from
+77 −36

Conversation

@Harikrishnan1367709
Copy link
Contributor

@Harikrishnan1367709 Harikrishnan1367709 commented Nov 3, 2025

Makes the accessToken field optional for ntfy notifications since not all ntfy topics require authentication.

Changes:

  • Frontend/backend: Made accessToken optional in validation schemas
  • Database: Made accessToken column nullable
  • Service: Updated to conditionally include Authorization header
  • Migration: Added to alter database constraint

Fixes #2938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siumauricio Siumauricio Awaiting requested review from Siumauricio Siumauricio is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not all ntfy topics need access tokens

1 participant

@Harikrishnan1367709