Skip to content

Conversation

@jayvdb
Copy link
Collaborator

@jayvdb jayvdb commented Nov 8, 2025

Removes build.rs script from butane crate, which did nothing except in development.

Related to #212

I suspect this might help with #212

@jayvdb jayvdb marked this pull request as ready for review November 8, 2025 01:00
@jayvdb jayvdb requested a review from Electron100 November 8, 2025 01:00
Copy link
Owner

@Electron100 Electron100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see any other advantage to this, or just worth trying as a solution to #212?

@jayvdb
Copy link
Collaborator Author

jayvdb commented Nov 9, 2025

Removing the build.rs is definitely a positive.

A negative is now an explicit Cargo.toml entry is needed for each test.

And there is a general "surprise" factor. e.g. we'll need to remember to do cargo test -p butane_tests instead of cargo test -p butane.
We could move butane_tests to the top level of the repo if that becomes a problem, likely when there are lots of new contributors who will be confused by butane/tests not using auto-discovery.

Also there are Rust infrastructure which run the tests of crates to check for potential problems with new language syntax or features, so removing the tests from butane is depriving such tools of our tests. Not a serious problem IMO.

@jayvdb jayvdb merged commit d8a3775 into Electron100:master Nov 9, 2025
7 checks passed
@jayvdb jayvdb deleted the mv-tests branch November 9, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants