Skip to content

Allow :insert command to load 3rd party assets #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ccuser44 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow :insert command to load 3rd party assets #2019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f1c64
Allow `:insert` command to load 3rd party assets
ccuser44 Nov 23, 2025
503b178
Fix typo
ccuser44 Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MainModule/Shared/Service.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,7 +1362,7 @@ return function(errorHandler, eventChecker, fenceSpecific, env)
UnallowedCache = {},
Insert = function(id, rawModel)
if service.UnallowedCache and service.UnallowedCache[id] then return end
local model = service.InsertService:LoadAsset(id)
local model = ({xpcall(function() return nil, service.AssetService:LoadAssetAsync(id) end, warn)})[3] or service.InsertService:LoadAsset(id)
if not rawModel and model:IsA("Model") and model.Name == "Model" then
local asset = model:GetChildren()[1]
asset.Parent = model.Parent
Expand Down
Loading