WIP: Allow joining public clans w/o invite token #362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brutus5000
force-pushed
the
feature/public-clans
branch
from
b8a4226 to
999268b
Compare
Brutus5000
force-pushed
the
feature/public-clans
branch
from
999268b to
1e9a7be
Compare
bukajsytlos
reviewed
Nov 11, 2019
|
|
||
| public Player getPlayer(Authentication authentication) { | ||
| public Player getCurrentPlayer() { | ||
| Authentication authentication = SecurityContextHolder.getContext().getAuthentication(); |
Member
There was a problem hiding this comment.
I am not sure if UserSupplier could be used here, or it is being redundant due to this change
Member
Author
There was a problem hiding this comment.
I wouldn't know a case where you have User instead of a Player except for the current logged in one.
Brutus5000
force-pushed
the
feature/public-clans
branch
4 times, most recently
from
78b3aec to
75de6d1
Compare
Closed
norraxx
reviewed
Nov 29, 2019
| produces = APPLICATION_JSON_UTF8_VALUE) | ||
| @ApiResponse(code = 200, message = "Success with JSON { jwtToken: ? }"), | ||
| @ApiResponse(code = 400, message = "Bad Request")}) | ||
| @GetMapping(path = "/generateInvitationLink", produces = APPLICATION_JSON_VALUE) |
| private String description; | ||
| private String tagColor; | ||
| private String websiteUrl; | ||
| private Boolean requiresInvitation = Boolean.TRUE; |
There was a problem hiding this comment.
Is that Boolean because of database definitions?
Member
There was a problem hiding this comment.
needs to be Boolean instead of boolean if it is nullable
Brutus5000
force-pushed
the
feature/public-clans
branch
from
a247a0d to
207dd17
Compare
Brutus5000
force-pushed
the
feature/public-clans
branch
4 times, most recently
from
81295e6 to
a9c8c3a
Compare
1-alex98
reviewed
Jul 6, 2020
Brutus5000
force-pushed
the
feature/public-clans
branch
8 times, most recently
from
cf5ab3e to
e345c1a
Compare
Brutus5000
force-pushed
the
feature/public-clans
branch
from
e345c1a to
2879712
Compare
Member
Author
|
Closed in favor of #428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.