-
-
Notifications
You must be signed in to change notification settings - Fork 23.1k
feat: add Zendesk document loader and credential integration #5452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add Zendesk document loader and credential integration #5452
Conversation
Introduce a new Zendesk document loader and corresponding credential class to facilitate the extraction of articles from the Zendesk Knowledge Base. This includes configuration validation, error handling, and support for chunking large articles. Additionally, a new SVG icon for Zendesk is added, along with comprehensive tests to ensure functionality.
Summary of ChangesHello @davehamptonusa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new integration with Zendesk, enabling the platform to load articles from Zendesk Knowledge Bases. It provides a complete solution for authenticating, fetching, and processing Zendesk articles, including intelligent handling of large content through chunking. This enhancement significantly expands the platform's data ingestion capabilities from external knowledge sources. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Zendesk document loader and credential integration. The implementation is solid, with good error handling for API requests and comprehensive tests. I've identified a few areas for improvement, primarily in the main loader implementation, focusing on adding validation for the required locale parameter, refactoring metadata handling for better robustness and clarity, and removing a misleading code comment. The accompanying tests are thorough and well-structured.
| } | ||
| } | ||
| } catch (error: any) { | ||
| // Continue with other locales if one fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ocale support
Updated the Zendesk document loader to use a default locale ('en-us') when none is provided and to support comma-separated locales for fetching articles. Improved test cases to validate these changes, ensuring proper handling of multiple locales and default behavior. Enhanced error handling for locale validation and metadata processing.
Introduce a new Zendesk document loader and corresponding credential class to facilitate the extraction of articles from the Zendesk Knowledge Base. This includes configuration validation, error handling, and support for chunking large articles. Additionally, a new SVG icon for Zendesk is added, along with comprehensive tests to ensure functionality.