Sentence casing part 1 #8273
Draft
Sentence casing part 1 #8273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
absidue and
kommunarr
PikachuEXE
reviewed
Nov 13, 2025
absidue
reviewed
Nov 24, 2025
static/locales/en-US.yaml
Outdated
Comment on lines
32
to
36
| Version {versionNumber} is now available! Click for more details.: Version {versionNumber} is now available! Click | ||
| for more details. | ||
| Download from site: Download from site | ||
| A new blog is now available, {blogTitle}. Click to view more.: A new blog is now available, {blogTitle}. | ||
| Click to view more. |
Member
There was a problem hiding this comment.
I would prefer to keep periods out keys if possible, as it makes using the translation strings more annoying t('parent.key without a period') vs t('parent["key with . a period"]'), I don't mind adding them to the values/the actual strings.
Off-topic: I would prefer to use shorter keys in general, even if that means that the key doesn't match the text.
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
#5000
Description
This PR is drafted because i'd like to reach a consensus on the changes first before i change all the related files
Notable changes:
https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube/blob/5c7be48e038b60e32366ca591bcf8c1f65e351b9/static/locales/en-US.yaml#L4-L26 is made the same as browser and other Electron application menu bars
General rules of thumb im adhering to in all my PR's:
If you want to import your subscriptions you can go to **Data settings** and select **Import subscriptions** or you can search for a channel and subscribe to them.)Testing
Look around in the UI to check that sentence casing has been applied properly
Desktop