Skip to content

Conversation

@jinbaebang
Copy link

@jinbaebang jinbaebang commented Oct 23, 2025

Description

This PR proposes the addition of new Helm chart samples to support the Application Design Center (ADC). These templates are designed to provide standardized, ready-to-use workload definitions for various GKE environments.

The new samples will be located under the /app-design-center directory and will follow the existing structure found in my fork. The proposed structure is:

/app-design-center
├── ai-inference/
├── enterprise-production/
├── simple-app-multi-region/
└── simple-app-single-region/

Tasks

  • The contributing guide has been read and followed.
  • The samples added / modified have been fully tested.
  • Workflow files have been added / modified, if applicable.
  • Region tags have been properly added, if new samples.
  • Editable variables have been used, where applicable.
  • All dependencies are set to up-to-date versions, as applicable.
  • Merge this pull-request for me once it is approved.

@jinbaebang jinbaebang requested review from a team and yoshi-approver as code owners October 23, 2025 15:23
@@ -0,0 +1,3 @@
# AI Inference Helm Chart

These samples show how to deploy a Gemma 2 27B model for inference. Visit https://cloud.google.com/kubernetes-engine/docs/ to follow the tutorial.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should we link to https://cloud.google.com/application-design-center/docs/build-on-google-templates instead?

Suggested change
These samples show how to deploy a Gemma 2 27B model for inference. Visit https://cloud.google.com/kubernetes-engine/docs/ to follow the tutorial.
These samples show how to deploy a Gemma 2 27B model for inference. Visit https://cloud.google.com/application-design-center/docs/build-on-google-templates to follow the tutorial.

@@ -0,0 +1,3 @@
# Enterprise Production Helm Chart

These samples show how to deploy a stateless web application for production. Visit https://cloud.google.com/kubernetes-engine/docs/ to follow the tutorial.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should we link to https://cloud.google.com/application-design-center/docs/build-on-google-templates instead?

Suggested change
These samples show how to deploy a stateless web application for production. Visit https://cloud.google.com/kubernetes-engine/docs/ to follow the tutorial.
These samples show how to deploy a stateless web application for production. Visit https://cloud.google.com/application-design-center/docs/build-on-google-templates for instructions.

@@ -0,0 +1,3 @@
# Simple App Multi-Region Helm Chart

These samples show how to deploy a multi-region web application. Visit https://cloud.google.com/kubernetes-engine/docs/ to follow the tutorial.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should we link to https://cloud.google.com/application-design-center/docs/build-on-google-templates instead?

Suggested change
These samples show how to deploy a multi-region web application. Visit https://cloud.google.com/kubernetes-engine/docs/ to follow the tutorial.
These samples show how to deploy a multi-region web application. Visit https://cloud.google.com/application-design-center/docs/build-on-google-templates for instructions.

@@ -0,0 +1,3 @@
# Simple App Single-Region Helm Chart

These samples show how to deploy a simple web application in a single region. Visit https://cloud.google.com/kubernetes-engine/docs/ to follow the tutorial.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should we link to https://cloud.google.com/application-design-center/docs/build-on-google-templates instead?

Suggested change
These samples show how to deploy a simple web application in a single region. Visit https://cloud.google.com/kubernetes-engine/docs/ to follow the tutorial.
These samples show how to deploy a simple web application in a single region. Visit https://cloud.google.com/application-design-center/docs/build-on-google-templates for instructions.

@@ -0,0 +1,74 @@
{{/*
Copyright 2025 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Thanks for adding these licenses headers (even in the .tpl files)! :)

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very well done! Thank you, @jinbaebang, for these samples. :)

Approved. I just left a few questions about the URLs in the README.mds.

Copy link
Collaborator

@NimJay NimJay Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Thanks for adding this GitHub Action for testing the Helm charts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants