Skip to content

Support attributes option alongside cleanId for toHTML operations #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Support attributes option alongside cleanId for toHTML operations #6642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f583c38
Support `attributes` option alongside `cleanId` for `toHTML` operations
DavidHarvey Nov 9, 2025
adf0358
whoops
DavidHarvey Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions packages/core/src/code_manager/model/HtmlGenerator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,22 @@ export default class HTMLGenerator extends Model {
})
.filter(Boolean);

if (!htmlOpts.attributes) {
htmlOpts.attributes = (mod, attrs) => {
const { id } = attrs;
if (
id &&
id[0] === 'i' && // all autogenerated IDs start with 'i'
!mod.get('script') && // if the component has script, we have to leave the ID
!mod.get('script-export') && // if the component has script, we have to leave the ID
!mod.get('attributes')!.id && // id is not intentionally in attributes
idRules.indexOf(id) < 0 // we shouldn't have any rule with this ID
) {
delete attrs.id;
}
return attrs;
};
}
const attributes = htmlOpts.attributes;
htmlOpts.attributes = (mod, attrs) => {
attrs = typeof attributes === 'function' ? attributes(mod, attrs) : attrs;
const { id } = attrs;
if (
id &&
id[0] === 'i' && // all autogenerated IDs start with 'i'
!mod.get('script') && // if the component has script, we have to leave the ID
!mod.get('script-export') && // if the component has script, we have to leave the ID
!mod.get('attributes')!.id && // id is not intentionally in attributes
idRules.indexOf(id) < 0 // we shouldn't have any rule with this ID
) {
delete attrs.id;
}
return attrs;
};
}

return model.toHTML(htmlOpts);
Expand Down