Skip to content

Get /organizations/{id} change the order for associated planters #243 #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MundhadHarsh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Get /organizations/{id} change the order for associated planters #243 #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"express-validator": "^6.4.0",
"joi": "^17.5.0",
"knex": "^0.95.14",
"loglevel": "^1.6.8",
"loglevel": "^1.8.0",
Copy link
Contributor

@dadiorchen dadiorchen Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) @MundhadHarsh what's the motivation to upgrade this lib

Copy link
Author

@MundhadHarsh MundhadHarsh Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadiorchen it was not importing log from loglevel that's why I had to upgrade

"pg": "^8.7.1",
"rascal": "^14.4.0",
"response-time": "^2.3.2",
Expand Down
2 changes: 1 addition & 1 deletion server/models/Organization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function getByFilter(
function getOrganizationLinks(organization) {
const links = {
featured_trees: `/trees?organization_id=${organization.id}&limit=20&offset=0`,
associated_planters: `/planters?organization_id=${organization.id}&limit=20&offset=0`,
associated_planters: `/planters?organization_id=${organization.id}&limit=20&offset=0&order_by=about`,
Copy link
Contributor

@dadiorchen dadiorchen Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MundhadHarsh did you test this feature, I mean, with this order_by parameter, the SQL will try to add corresponding phrase?

Copy link
Author

@MundhadHarsh MundhadHarsh Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have not tested the feature. I made changes given in the description of #243

species: `/species?organization_id=${organization.id}&limit=20&offset=0`,
};
return links;
Expand Down