src/nettest_bsd.c: Assign the return value of netperf_sendfile to len #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
len is declared but not assigned in sendfile_tcp_stream() so that running netperf -t TCP_SENDFILE in loops may get random and unexpected len, for example: netperf: data send error: sendfile: No space left on device len was -1334480592 send_size was 10240 Add the missing assignment to fix the issue. Reported-by: kernel test robot <[email protected]> Signed-off-by: Xiao Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
len is declared but not assigned in sendfile_tcp_stream() so that
running netperf -t TCP_SENDFILE in loops may get random and unexpected
len, for example:
netperf: data send error: sendfile: No space left on device
len was -1334480592 send_size was 10240
Add the missing assignment to fix the issue.
Reported-by: kernel test robot [email protected]
Signed-off-by: Xiao Yang [email protected]