[email protected]: include major_minor version in pear path #253570
Conversation
this is how it's done in other old versions and is required to support multiple versions installed at once without this, both [email protected] and php(@8.4) point to the same pear directory, and cannot use separate pear extension versions we copy over the previous non-versioned directory if one exists to ensure any existing pecl install data is retained
github-actions
bot
added
legacy
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
Formula/p/[email protected]
Outdated
| # copy over non-versioned pear path if it exists and the versioned path does not | ||
| non_versioned_pear_path = HOMEBREW_PREFIX/"share/pear" | ||
| if non_versioned_pear_path.exist? && !pear_path.exist? | ||
| cp_r non_versioned_pear_path, pear_path | ||
| end | ||
|
|
There was a problem hiding this comment.
Is it needed? Other PHP formulae do not have it
There was a problem hiding this comment.
we need it for backwards compatibility, I think
if someone has already installed [email protected] and installed pecl packages, this is needed to prevent this from wiping out the existing pear directory. otherwise pecl gets into a weird state where it thinks packages aren't installed, but they actually are
There was a problem hiding this comment.
Mostly user will get updates to 8.4 and so the path does not need to be backward compatible. If someone explicitly use 8.3, then the config should be moved manually, same as 8.1 and 8.2.
github-actions
bot
added
the
autosquash
3 participants
this is how it's done in other old versions and is required to support multiple versions installed at once
without this, both [email protected] and php(@8.4) point to the same pear directory, and cannot use separate pear extension versions
we copy over the previous non-versioned directory if one exists to
ensure any existing pecl install data is retained
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?