KeycloakConfig retrieval should use the sslContext #2280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lampajr
requested changes
Feb 26, 2025
Member
lampajr
left a comment
lampajr
left a comment
There was a problem hiding this comment.
Hi @diegolovison, thanks for the fix.
Overall looks good but can you please add a test that ensure the behavior would be the expected one, if possible? For instance here https://github.com/Hyperfoil/Horreum/blob/d437b3652b8414ab6b5bab878772a0e110df0279/horreum-integration-tests/src/test/java/io/hyperfoil/tools/horreum/it/HorreumClientIT.java where we have all the tests using the HorreumClient
Contributor
Author
|
Let me think about the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
All http requests should use the sslContext configured
Check List (Check all the applicable boxes)