Use icinga-go-library
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
switch-to-igl
branch
from
0223bed to
387ce31
Compare
yhabteab
force-pushed
the
switch-to-igl
branch
2 times, most recently
from
4a65442 to
4153415
Compare
yhabteab
force-pushed
the
switch-to-igl
branch
from
4153415 to
fa519f9
Compare
yhabteab
force-pushed
the
switch-to-igl
branch
3 times, most recently
from
20f1849 to
88e5158
Compare
yhabteab
force-pushed
the
switch-to-igl
branch
from
88e5158 to
996fd95
Compare
This was referenced Apr 12, 2024
Closed
yhabteab
force-pushed
the
switch-to-igl
branch
2 times, most recently
from
6287c2e to
4ae3893
Compare
Member
Author
|
I had to use the new, not yet merged PR as the icinga-notifications/internal/event/event.go Lines 136 to 137 in 4ae3893 |
yhabteab
force-pushed
the
switch-to-igl
branch
4 times, most recently
from
0e466c9 to
b68f4f6
Compare
julianbrost
reviewed
May 29, 2024
yhabteab
force-pushed
the
switch-to-igl
branch
2 times, most recently
from
cf958eb to
bba22c5
Compare
oxzi
reviewed
May 31, 2024
Member
oxzi
left a comment
oxzi
left a comment
There was a problem hiding this comment.
Please feel free removing the now unused utils functions. Otherwise, LGTM.
oxzi
previously approved these changes
May 31, 2024
julianbrost
reviewed
Jun 3, 2024
go.mod
Outdated
| github.com/goccy/go-yaml v1.11.3 | ||
| github.com/google/uuid v1.6.0 | ||
| github.com/icinga/icingadb v1.1.1-0.20230418113126-7c4b947aad3a | ||
| github.com/icinga/icinga-go-library v0.1.1-0.20240529153148-5054d55f8005 |
Collaborator
There was a problem hiding this comment.
I just tagged the new version as v0.2.0, please update this to use the tagged version.
The `context.Context` related changes are neccessary as otherwise you will have to wait for 5m when having Icinga notification started with invalid database config due to the internal database.Connect retrials. Lastly, the logging related changes are useful as we want to properly render the stack traces when we unexpectedly exit from the main function instead of wrapping the error in a confusing `zap.Error()` json key.
julianbrost
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked By
DB#BuildColumns()icinga-go-library#22