-
Notifications
You must be signed in to change notification settings - Fork 282
Fix mobile/minimal layout layout #5381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ The header scrolling problem seems to be fixed.
✅ I noticed that the expanded menu takes now full height, which is a good side effect.
I also noticed weird hovering behavior in Safari with the menu. It won't happen in the Chrome inspector on Desktop, because it has hover effects disabled. It should though be tested on Android Chrome.
Screen.Recording.2025-11-10.at.09.09.04.mov
If the problem is Safari desktop only, we can ignore it, since it's not a very common use case. But on the other hand, it shouldn't be difficult to disable the opening of the '.level-2' submenu on hover.
We just investigated this and tested it on an actual phone. The Chrome inspector disables the hover behavior completely, so this is not reproducible there (Firefox also has an option to enable "touch mode"). iOS Safari still recoginzes the hover effect regardlessly. Besides that, the level-2 menus still appear on active/selected nav-items. We should completely disable the level-2 menus in .minimal mode to make sure the we don't run into any weird side-effects, so the navigation works via the dashboard sheets as intended. @sukhwinder: I'd suggest we track this in a different issue. |
|
please rebase |
99994b6 to
f7558d9
Compare
|
@cla-bot check |
fix #5386, fix #5023