Skip to content

Conversation

@sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jun 17, 2025

fix #5386, fix #5023

Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The header scrolling problem seems to be fixed.

✅ I noticed that the expanded menu takes now full height, which is a good side effect.

⚠️ The message in the list footer mentioned in #5386 is still there. We should either fix this here or keep track of it in another issue:

I also noticed weird hovering behavior in Safari with the menu. It won't happen in the Chrome inspector on Desktop, because it has hover effects disabled. It should though be tested on Android Chrome.

Screen.Recording.2025-11-10.at.09.09.04.mov

If the problem is Safari desktop only, we can ignore it, since it's not a very common use case. But on the other hand, it shouldn't be difficult to disable the opening of the '.level-2' submenu on hover.

@flourish86
Copy link
Contributor

I also noticed weird hovering behavior in Safari with the menu. It won't happen in the Chrome inspector on Desktop, because it has hover effects disabled. It should though be tested on Android Chrome.

Screen.Recording.2025-11-10.at.09.09.04.mov

If the problem is Safari desktop only, we can ignore it, since it's not a very common use case. But on the other hand, it shouldn't be difficult to disable the opening of the '.level-2' submenu on hover.

We just investigated this and tested it on an actual phone. The Chrome inspector disables the hover behavior completely, so this is not reproducible there (Firefox also has an option to enable "touch mode"). iOS Safari still recoginzes the hover effect regardlessly.

Besides that, the level-2 menus still appear on active/selected nav-items. We should completely disable the level-2 menus in .minimal mode to make sure the we don't run into any weird side-effects, so the navigation works via the dashboard sheets as intended.

@sukhwinder: I'd suggest we track this in a different issue.

@nilmerg
Copy link
Member

nilmerg commented Nov 12, 2025

please rebase

@nilmerg
Copy link
Member

nilmerg commented Nov 13, 2025

@cla-bot check

@nilmerg nilmerg added this to the 2.12.6 milestone Nov 13, 2025
@nilmerg nilmerg merged commit a545279 into main Nov 13, 2025
10 checks passed
@nilmerg nilmerg deleted the fix/mobile-layout branch November 13, 2025 08:13
nilmerg added a commit that referenced this pull request Nov 18, 2025
fix #5386, fix #5023

(cherry picked from commit a545279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Minimal layout Header scrollable on mobile view

4 participants