Skip to content

Use NotWritableError for ini config #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use NotWritableError for ini config #5404

wants to merge 2 commits into from

Conversation

@jrauh01
Copy link
Contributor

@jrauh01 jrauh01 commented Aug 11, 2025 •
edited
Loading

Replaced the unused Zend_Config_Exception with a more appropriate NotWritableError in IniWriter::write().

  • The old Zend_Config_Exception was never caught anywhere in the codebase.
  • Changed to NotWritableError to better reflect file permission and write issues.
  • Added @ suppression to the file_put_contents() call so that the method can throw NotWritableError instead of crashing on PHP warnings.

@jrauh01 jrauh01 self-assigned this Aug 11, 2025
@cla-bot cla-bot bot added the cla/signed label Aug 11, 2025
@jrauh01 jrauh01 requested a review from lippserd August 11, 2025 11:38
@jrauh01 jrauh01 mentioned this pull request Aug 11, 2025
Open
sukhwinder33445
sukhwinder33445 approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sukhwinder33445 sukhwinder33445 sukhwinder33445 approved these changes

@lippserd lippserd Awaiting requested review from lippserd

Assignees

@jrauh01 jrauh01

Labels

cla/signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jrauh01 @sukhwinder33445