Replace outdated test setup code with composer.json
#5445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparation for a GitHub action to streamline tests, which expects the `phpunit.xml` configuration at the root level.
Also, we could require our PHP libraries as soon as we have uploaded them to Packagist.
Else, tests with current PHPUnit versions fail with `Cannot override final method PHPUnit\Framework\Assert::assertMatchesRegularExpression()`.
lippserd
force-pushed
the
test-setup-vendor
branch
from
4ff8820 to
eabb806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for a GitHub action to streamline tests, which
phpunit.xmlconfiguration at the root level, andcomposer.Proof that the same number of tests are run after moving the configuration file:
Rationale for introducing
composer:GitHub Actions for this repository and any other module that requires Mockery must specify this dependency themselves. Module tests require Icinga Web anyway, so all (development) dependencies and any changes to them should be automatically applied instead of having to adjust each individual module affected. If we eventually upload our library bundles to Packagist as well, we could also specify them in
composer.jsononce instead of having to require them in every action.