Skip to content

Update common tracking #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update common tracking #5609

wants to merge 3 commits into from

Conversation

@mathstuf
Copy link
Contributor

@mathstuf mathstuf commented Nov 7, 2025

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Cc: @bradking @thewtex

@github-actions github-actions bot added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Nov 7, 2025
@mathstuf
STYLE: git-fetch-file: track update-common.sh
99c9c92 
Support using `git fetch-file`[1] to keep `update-common.sh`
synchronized with its upstream.

[1] https://github.com/andrewmcwattersandco/git-fetch-file
@mathstuf
ENH: update-common.sh: synchronize with upstream
1bc9826 
Of note is the support for finding imports with matching trees, not just
commits.
@mathstuf mathstuf force-pushed the update-common-tracking branch from 169b552 to 1bc9826 Compare November 7, 2025 20:41
@dzenanz dzenanz requested a review from bradking November 7, 2025 21:06
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:ThirdParty Issues affecting the ThirdParty module labels Nov 9, 2025
hjmjohnson
hjmjohnson requested changes Nov 10, 2025
View reviewed changes
Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathstuf The commit message is invalid. Please run ./Utilities/SetupForDevelopment.sh to have the commit messages validated before the PR is updated.

Thanks for the contribution.

@mathstuf
STYLE: thirdparty: disable exact tree matching
78982a2 
Except for Eigen and KWSys which are exact tree imports.
@mathstuf mathstuf force-pushed the update-common-tracking branch from be1e755 to 78982a2 Compare November 10, 2025 17:49
@mathstuf
Copy link
Contributor Author

mathstuf commented Nov 10, 2025

I marked it as STYLE because I don't see a better category for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson hjmjohnson requested changes

@bradking bradking Awaiting requested review from bradking

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

area:ThirdParty Issues affecting the ThirdParty module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathstuf @hjmjohnson