Skip to content

Conversation

@Hrishi-Baskaran
Copy link

@Hrishi-Baskaran Hrishi-Baskaran commented Nov 8, 2025

Closes #13794

This fixes an issue with the consistency check. The consistency check is not supposed to check for required fields but does anyways. It does it incorrectly regardless. I removed the check for required fields entirely and modified the relevant test cases. I next plan to write tests for consistency checks that involve the entry type manager for custom entry types. I do not need feedback yet, but I don't mind receiving some.

Steps to test

One can test this feature by running the relevant test case: BibliographyConsistencyCheckTest.checkFieldEntriesWithFieldDifferences.

Mandatory checks

This method was not intended to check for required fields according to
its documentation. Even then, the way how it handled checking for
required fields was incorrect for OrFields.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

Hey @Hrishi-Baskaran!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️.

We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

@jabref-machine
Copy link
Collaborator

JUnit tests of jablib are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support customized entry types in BibliographyConsistencyCheck

2 participants