Fixes and Extends BibliographyConsistencyCheck.check to Handle Custom Entry Types #14257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13794
This fixes an issue with the consistency check. The consistency check is not supposed to check for required fields but does anyways. It does it incorrectly regardless. I removed the check for required fields entirely and modified the relevant test cases. I next plan to write tests for consistency checks that involve the entry type manager for custom entry types. I do not need feedback yet, but I don't mind receiving some.
Steps to test
One can test this feature by running the relevant test case: BibliographyConsistencyCheckTest.checkFieldEntriesWithFieldDifferences.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)