Write Pulseq #284
Open
Write Pulseq #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 92.60% 93.64% +1.03%
==========================================
Files 33 34 +1
Lines 2245 2500 +255
==========================================
+ Hits 2079 2341 +262
+ Misses 166 159 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cncastillo
reviewed
Jan 27, 2024
| """ | ||
| For comparing two `Sequence`s custom types | ||
| """ | ||
| Base.isapprox(s1::Sequence, s2::Sequence) = begin |
Member
There was a problem hiding this comment.
The syntax Base.isapprox instead of import Base: isapprox is not consistent with the rest of the code. Julia Blue (#187) recommends Base.isapprox, we need to choose one or the other.
cncastillo
reviewed
Jan 27, 2024
cncastillo
reviewed
Jan 27, 2024
cncastillo
reviewed
Jan 27, 2024
cncastillo
reviewed
Jan 27, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cncastillo
requested changes
Apr 24, 2024
Member
cncastillo
left a comment
cncastillo
left a comment
There was a problem hiding this comment.
Please do not modify the reader, and remove aux functions, as we have discussed multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is meant to address issue #152