Skip to content

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 31, 2025

With thanks to Ian and Kristoffer for pointing out the needed fixes

  • Will need: runtests(ALL, configuration = (goal=:load,), vs_configuration = (goal=:load,)) before merge

@giordano giordano added needs pkgeval Tests for all registered packages should be run with this change re-land This relands a PR that was previously merged but was later reverted. labels Oct 31, 2025
@vtjnash
Copy link
Member Author

vtjnash commented Nov 4, 2025

@nanosoldier runtests(ALL, configuration = (goal=:load,), vs_configuration = (goal=:load,))

@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing don't squash Don't squash merge and removed needs pkgeval Tests for all registered packages should be run with this change labels Nov 4, 2025
@KristofferC KristofferC mentioned this pull request Nov 5, 2025
17 tasks
@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

327 packages failed only on the current version.

  • Package fails to precompile: 213 packages
  • Illegal method overwrites during precompilation: 108 packages
  • Package requires a missing binary dependency: 2 packages
  • Test duration exceeded the time limit: 4 packages

949 packages failed on the previous version too.

~ Packages that at least loaded

2 packages successfully loaded only on the current version.

  • Other: 2 packages

8941 packages successfully loaded on the previous version too.

➖ Packages that were skipped altogether

1 packages were skipped only on the current version.

  • Package could not be installed: 1 packages

889 packages were skipped on the previous version too.

@vtjnash vtjnash removed the merge me PR is reviewed. Merge when all tests are passing label Nov 5, 2025
Some packages add extensions to stdlibs, so we should not have
prohibited precompiling those. This broke Compat, which adds an
extension to LinearAlgebra.
@vtjnash
Copy link
Member Author

vtjnash commented Nov 7, 2025

We may need to completely rethink how extensions to stdlibs work again, since this is now just a hack job to only be partly badly implemented, since the trigger sets being used for computing the safe operation are entirely wrong if any of them got added into a custom sysimage.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 7, 2025
@IanButterworth
Copy link
Member

That sounds like a merge blocker? Stdlibs are very commonly added to custom sysimages?

@fingolfin fingolfin removed the merge me PR is reviewed. Merge when all tests are passing label Nov 10, 2025
@vtjnash
Copy link
Member Author

vtjnash commented Nov 10, 2025

I mention it because it is a pre-existing mistake, not because it is introduced here

@vtjnash vtjnash merged commit 5fcc944 into master Nov 10, 2025
9 checks passed
@vtjnash vtjnash deleted the jn/reapply-59765 branch November 10, 2025 17:54
@KristofferC
Copy link
Member

I don't know if #52841 is relevant but it was trying to make the set of packages in the sysimage irrelevant to what extensions are loaded. But it was buggy.

@vtjnash
Copy link
Member Author

vtjnash commented Nov 10, 2025

Yep, it was basically the same as that issue. But also making the observation that the resulting hack there (#55589) could be badly broken in the case of trying to compute the dependency graph of something that got added to the sysimg because it may refuse to load extensions for subsets of dependencies if all of those are in the sysimg (because that would incur a dependency cycle and not be solvable / loadable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.13 don't squash Don't squash merge re-land This relands a PR that was previously merged but was later reverted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants