-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Reapply "precompile: fail in (closer to) linear time and linear error messages" with fixes #60000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e3421e6 to
7d6ae45
Compare
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary✖ Packages that failed327 packages failed only on the current version.
949 packages failed on the previous version too. ~ Packages that at least loaded2 packages successfully loaded only on the current version.
8941 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether1 packages were skipped only on the current version.
889 packages were skipped on the previous version too. |
Some packages add extensions to stdlibs, so we should not have prohibited precompiling those. This broke Compat, which adds an extension to LinearAlgebra.
… messages" This reverts commit 81dbb72.
7d6ae45 to
cd0d942
Compare
|
We may need to completely rethink how extensions to stdlibs work again, since this is now just a hack job to only be partly badly implemented, since the trigger sets being used for computing the safe operation are entirely wrong if any of them got added into a custom sysimage. |
|
That sounds like a merge blocker? Stdlibs are very commonly added to custom sysimages? |
|
I mention it because it is a pre-existing mistake, not because it is introduced here |
|
I don't know if #52841 is relevant but it was trying to make the set of packages in the sysimage irrelevant to what extensions are loaded. But it was buggy. |
|
Yep, it was basically the same as that issue. But also making the observation that the resulting hack there (#55589) could be badly broken in the case of trying to compute the dependency graph of something that got added to the sysimg because it may refuse to load extensions for subsets of dependencies if all of those are in the sysimg (because that would incur a dependency cycle and not be solvable / loadable) |
With thanks to Ian and Kristoffer for pointing out the needed fixes
runtests(ALL, configuration = (goal=:load,), vs_configuration = (goal=:load,))before merge