Skip to content

Conversation

@dgleich
Copy link
Contributor

@dgleich dgleich commented Oct 31, 2024

Titles says it all. Base now has tanpi and this should extend that function.

@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.56%. Comparing base (fd2ec2d) to head (91896af).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   50.25%   50.56%   +0.31%     
==========================================
  Files          63       63              
  Lines        3536     3536              
==========================================
+ Hits         1777     1788      +11     
+ Misses       1759     1748      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffreySarnoff
Copy link
Member

Just importing tanpi does not provide a DoubleFloat version of tanpi. What is the intent?

@dgleich
Copy link
Contributor Author

dgleich commented Nov 3, 2024

There's already a tanpi function for double floats. This just extends the base method instead of exporting a new method.

@JeffreySarnoff JeffreySarnoff merged commit dce2480 into JuliaMath:main Nov 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants