Remove not_standard_first_version check
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check shows this message: ``` Also, note the warning: This looks like a new registration that registers version 0.1.1. Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request. ``` This is confusing (it prompts users to change version number even if they do not have to) and false: it is not true that changing the version number and registering again will update the pull request, on the contrary it will open a new pull request which will never be merged because it will conflict with the previously opened PR.
DilumAluthge
approved these changes
Dec 10, 2021
GunnarFarneback
approved these changes
Oct 23, 2022
| status = Symbol[:new_package, :new_package_label, | ||
| :not_standard_first_version], | ||
| status = Symbol[:new_package, :new_package_label], | ||
| regbranch = (error = false, warning = true, |
Collaborator
There was a problem hiding this comment.
Also needs to set warning = false.
| status = Symbol[:new_package, :new_package_label, :version_zero, | ||
| :not_standard_first_version], | ||
| status = Symbol[:new_package, :new_package_label, :version_zero], | ||
| regbranch = (error = true, warning = true, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check shows this message:
This is confusing (it prompts users to change version number even if they do not
have to) and false: it is not true that changing the version number and
registering again will update the pull request, on the contrary it will open a
new pull request which will never be merged because it will conflict with the
previously opened PR.