Skip to content

Revert "Write empty Deps.toml and Compat.toml files, but don't write empty WeakDeps.toml or WeakCompat.toml files" #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert "Write empty Deps.toml and Compat.toml files, but don't write empty WeakDeps.toml or WeakCompat.toml files" #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57a354
Revert "Write empty `Deps.toml` and `Compat.toml` files, but don't wr…
DilumAluthge Feb 17, 2023
13adcde
Add some comments about how it is intentional that we don't write cer…
DilumAluthge Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions src/register.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,14 +387,8 @@ function update_deps_file(pkg::Project,
end

deps_data[pkg.version] = deps
if file == "Deps.toml"
# We always write the `Deps.toml` file, even if it is empty
write_this_file = true
else
# We only write the `WeakDeps.toml` file if it is not empty
write_this_file = !isempty(deps_data) && !all(isempty, values(deps_data))
end
if write_this_file
if !isempty(deps_data) && !all(isempty, values(deps_data))
# We intentionally do not write empty `Deps.toml` or `WeakDeps.toml` files
Compress.save(deps_file, deps_data)
end
end
Expand Down Expand Up @@ -498,14 +492,8 @@ function update_compat_file(pkg::Project,
end

compat_data[pkg.version] = d
if file == "Compat.toml"
# We always write the `Compat.toml` file, even if it is empty
write_this_file = true
else
# We only write the `WeakCompat.toml` file if it is not empty
write_this_file = !isempty(compat_data) && !all(isempty, values(compat_data))
end
if write_this_file
if !isempty(compat_data) && !all(isempty, values(compat_data))
# We intentionally do not write empty `Compat.toml` or `WeakCompat.toml` files
Compress.save(compat_file, compat_data)
end
end
Expand Down