Add locale picker to the ServerItemRendererWithDebugUI #2861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…temRendererWithDebugUI
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: 0 B Total Size: 492 kB ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f3f8193) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2861If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR2861If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR2861 |
…emRendererWithDebugUI to have a locale picker
SonicScrewdriver
added a commit
that referenced
this pull request
Sep 22, 2025
## Summary: This PR adds support for locales (particularly Ukraine) that use `:` instead of `/` for denoting division in math equations. We're only focusing on the Expression Widget as Numeric Input / Input Number do not support the division symbol. We're currently checking with the language advocates about how fractions are written in Ukrainian, but initial research is indicating that the bar `/` is still used in those cases. This PR does not update the actual icon on the keypad, as we're still waiting for design. We will update the keypad button (in the appropriate locales) in a future PR, after LEMS-3535 has been completed. ## Video Example: https://github.com/user-attachments/assets/dd358910-ec21-4e76-8cc1-4405f59b5002 Issue: LEMS-3435 ## Test plan: - New tests pass - Manual testing using my [draft locale dropdown feature](#2861) - No regressions noticed in existing tests Author: SonicScrewdriver Reviewers: SonicScrewdriver, nishasy Required Reviewers: Approved By: nishasy Checks: ✅ 10 checks were successful Pull Request URL: #2862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I was working on LEMS-3435 and found myself annoyed that I couldn't quickly test between languages.
While we could catch these things in automated tests, I do like having the ability to manually test locale-specific math, particularly for recreating international bugs!
Screen.Recording.2025-09-03.at.2.32.06.PM.mov
Test plan: