New save warning utility - Expression widget warnings #2985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dget warnings Implement the save warnings for the expression widget within the new save warning utility. Issue: https://khanacademy.atlassian.net/browse/LEMS-3643 Test plan: `pnpm jest packages/perseus/src/util/get-save-warnings-for-item.test.ts` Storybook `/?path=/story/editors-editorpage--with-save-warnings-new-util`
…arnings to new save warning utility. Not ready for use yet.
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +224 B (+0.05%) Total Size: 498 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (7e5ff57) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2985If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR2985If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR2985 |
…gs-util-2-expression
…gs-util-2-expression
github-actions
bot
added
schema-change
jeremywiebe
approved these changes
Oct 24, 2025
Comment on lines
98
to
142
| // TODO(LEMS-3643): Remove this function once the save warnings util is | ||
| // complete and in use. | ||
| getSaveWarnings: () => any = () => { | ||
| const issues: Array<any | string> = []; | ||
|
|
||
| if (this.props.answerForms.length === 0) { | ||
| issues.push("No answers specified"); | ||
| } else { | ||
| const hasCorrect = this.props.answerForms.some((form) => { | ||
| return form.considered === "correct"; | ||
| }); | ||
| if (!hasCorrect) { | ||
| issues.push("No correct answer specified"); | ||
| } | ||
|
|
||
| _(this.props.answerForms).each((form, ix) => { | ||
| if (this.props.value === "") { | ||
| issues.push(`Answer ${ix + 1} is empty`); | ||
| } else { | ||
| // note we're not using icu for content creators | ||
| const expression = KAS.parse(form.value, { | ||
| functions: this.props.functions, | ||
| }); | ||
| if (!expression.parsed) { | ||
| issues.push(`Couldn't parse ${form.value}`); | ||
| } else if ( | ||
| form.simplify && | ||
| !expression.expr.isSimplified() | ||
| ) { | ||
| issues.push( | ||
| `${form.value} isn't simplified, but is required" + | ||
| " to be`, | ||
| ); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| // TODO(joel) - warn about: | ||
| // - unreachable answers (how??) | ||
| // - specific answers following unspecific answers | ||
| // - incorrect answers as the final form | ||
| } | ||
|
|
||
| return issues; | ||
| }; |
Collaborator
There was a problem hiding this comment.
I wonder if one way to bridge across without having a copy of the code is to call the new function here instead of keeping this logic in place.
Suggested change
| // TODO(LEMS-3643): Remove this function once the save warnings util is | |
| // complete and in use. | |
| getSaveWarnings: () => any = () => { | |
| return getSaveWarningsForExpressionWidget(this.props); // Ah! I see... we might not have props that are the same as the actual widget options... ok, maybe this won't work. | |
| }; |
nishasy
commented
Oct 28, 2025
|
|
||
| // TODO(LEMS-3643): Remove this function once the save warnings util is | ||
| // complete and in use. | ||
| getSaveWarnings: () => any = () => { |
Contributor
Author
There was a problem hiding this comment.
I am having a hard time figuring out replace the code here with the save warnings code migrated to the expression utils to reduce duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement the save warnings for the expression widget within the new save warning utility.
Issue: https://khanacademy.atlassian.net/browse/LEMS-3643
Test plan:
pnpm jest packages/perseus/src/util/get-save-warnings-for-item.test.tsStorybook
/?path=/story/editors-editorpage--with-save-warnings-new-util