[Image] | (CX) | Put Image props in the editor in DOM order #3040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor in DOM order The editor currently has the props in this order: Alt text, Long description, title, caption. But they should actually be in DOM order: Title, Alt text, Long description, Caption Making that change here. Issue: none Test plan: Storybook `/?path=/story/widgets-image-editor-demo--populated`
…e props in the editor in DOM order
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
|
Size Change: -3 B (0%) Total Size: 498 kB
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (998e419) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3040If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3040If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3040 |
ivyolamit
approved these changes
Nov 17, 2025
Merged
mark-fitzgerald
pushed a commit
that referenced
this pull request
Nov 18, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#3032](#3032) [`9201e1887b`](9201e18) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Error Boundary] Add stack trace to error payload to aid in troubleshooting rendering errors ### Patch Changes - [#3045](#3045) [`099aeff249`](099aeff) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Error Boundary] Correct type for stack property in widget-rendering-error:ti ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`9201e1887b`](9201e18), [`099aeff249`](099aeff)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`9201e1887b`](9201e18), [`099aeff249`](099aeff)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#3046](#3046) [`b8e0ea16ff`](b8e0ea1) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Sync dependencies with Frontend - Updated dependencies \[[`9201e1887b`](9201e18), [`099aeff249`](099aeff)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#3032](#3032) [`9201e1887b`](9201e18) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Error Boundary] Add stack trace to error payload to aid in troubleshooting rendering errors - [#3046](#3046) [`b8e0ea16ff`](b8e0ea1) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Sync dependencies with Frontend - Updated dependencies \[[`9201e1887b`](9201e18), [`b8e0ea16ff`](b8e0ea1), [`099aeff249`](099aeff)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#3042](#3042) [`c9cfba3096`](c9cfba3) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Handle autogen aria label for open locked points - [#3046](#3046) [`b8e0ea16ff`](b8e0ea1) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Sync dependencies with Frontend - [#3040](#3040) [`9b50f4c44c`](9b50f4c) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Put Image props in the editor in DOM order - Updated dependencies \[[`9201e1887b`](9201e18), [`b8e0ea16ff`](b8e0ea1), [`099aeff249`](099aeff)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`9201e1887b`](9201e18), [`099aeff249`](099aeff)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`9201e1887b`](9201e18), [`099aeff249`](099aeff)]: - @khanacademy/[email protected] - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ⏭️ 2 checks have been skipped, ✅ 6 checks were successful Pull Request URL: #3041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The editor currently has the props in this order: Alt text, Long description, title, caption.
But they should actually be in DOM order: Title, Alt text, Long description, Caption
Making that change here.
Issue: none
Test plan:
Storybook
/?path=/story/widgets-image-editor-demo--populated