-
Notifications
You must be signed in to change notification settings - Fork 2
Set up release workflow for trusted publishing #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a277aa6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: 0 B Total Size: 4.58 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 52 52
Lines 724 724
Branches 209 210 +1
=========================================
Hits 724 724 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
somewhatabstract
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some inline questions that may mean a change or two is needed before landing.
| id-token: write # required for publishing to npm | ||
| contents: write # required to `git push` | ||
| pages: write # so we can deploy to GitHub pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Permissions edits are not additive to the defaults but replace them entirely; does this include all the default permissions that would be granted if we were not overriding things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Perseus repo, I see the repo setting is that Actions have read/write permissions for all scopes, by default.
I suspect this is what this repo also has. In Perseus, this set of permissions was sufficient, so I think this will work here also. We'll know as soon as we cut a release if I've missed one.
5634929 to
58ebf32
Compare
Summary:
This PR makes a few changes to the Github Actions release workflow to support Trusted Publishing. It removes the
NPM_TOKENis that is not needed (and relieves us from rotating tokens or having insecure, long-lived tokens in use).It also adds a step to upgrade
npmCLI as we need at least v11.5.1 to support OpenID Connect (which is used for Trusted Publishing).Issue: LEMS-3681
Test plan:
Land this PR and cut a release. All packages are marked with a
patchchangeset but should not be functionally different than the currently published versions. It will just allow us to ensure trusted publishing is working properly.