Skip to content

clone song bug + add one method #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philippe44 wants to merge 1 commit into
base: public/8.5
Choose a base branch
from
Open

clone song bug + add one method #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Slim/Player/Song.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ use strict;
use base qw(Slim::Utils::Accessor);

use Fcntl qw(SEEK_CUR SEEK_SET);
use Clone qw(clone);

use Slim::Utils::Log;
use Slim::Schema;
Expand Down Expand Up @@ -168,7 +169,7 @@ sub clonePlaylistSong {
);

foreach ('handler', @_playlistCloneAttributes) {
$new->init_accessor($_ => $old->$_());
$new->init_accessor($_ => clone($old->$_()));
}

$_liveCount++;
Expand Down
5 changes: 5 additions & 0 deletions Slim/Player/StreamingController.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,11 @@ sub _Playing {
main::INFOLOG && $log->info("Song " . $last_song->index() . " has now started playing");
$last_song->setStatus(Slim::Player::Song::STATUS_PLAYING);
$last_song->retryData(undef); # we are playing so we must be done retrying
if ($last_song->currentTrackHandler()->can('onPlay')) {
foreach my $player (@{$self->{'players'}}) {
$last_song->currentTrackHandler()->onPlay($player, $last_song);
}
}
}

# Update a few timestamps
Expand Down