feat: warning for new context with old devkit version #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supernovahs
changed the title
…always udpate it(don't forget )
grezle
requested changes
Jun 12, 2025
grezle
reviewed
Jun 18, 2025
Comment on lines
+136
to
+141
| VERSION=%s | ||
| ARCH=$(uname -m | tr '[:upper:]' '[:lower:]') | ||
| DISTRO=$(uname -s | tr '[:upper:]' '[:lower:]') | ||
| mkdir -p $HOME/bin | ||
| curl -sL "https://s3.amazonaws.com/eigenlayer-devkit-releases/${VERSION}/devkit-${DISTRO}-${ARCH}-${VERSION}.tar.gz" | tar xv -C "$HOME/bin" |
Collaborator
There was a problem hiding this comment.
Minor nit: lets make sure the whitespace is consistent here:
Suggested change
| VERSION=%s | |
| ARCH=$(uname -m | tr '[:upper:]' '[:lower:]') | |
| DISTRO=$(uname -s | tr '[:upper:]' '[:lower:]') | |
| mkdir -p $HOME/bin | |
| curl -sL "https://s3.amazonaws.com/eigenlayer-devkit-releases/${VERSION}/devkit-${DISTRO}-${ARCH}-${VERSION}.tar.gz" | tar xv -C "$HOME/bin" | |
| VERSION=%s | |
| ARCH=$(uname -m | tr '[:upper:]' '[:lower:]') | |
| DISTRO=$(uname -s | tr '[:upper:]' '[:lower:]') | |
| mkdir -p $HOME/bin | |
| curl -sL "https://s3.amazonaws.com/eigenlayer-devkit-releases/${VERSION}/devkit-${DISTRO}-${ARCH}-${VERSION}.tar.gz" | tar xv -C "$HOME/bin" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #158
Motivation:
If user accidentally have an old devkit version , but. an avs project with a unsupported(newer than what the current cli can support) context yaml , then the migration fails with not a proper indication as to what the error is , and the potential problems it can create
Modifications:
Now , user will get a warning when they run any command, with proper steps to rectify i.e update their cli version.
Result:
Less chances for user to corrupt their context
Testing:
Manual testing. Ran a 0.0.6 yaml with the current 0.0.5 yaml supported cli version.
Open questions: