Skip to content

chore: v1.9.0 upgrade script fixes #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ypatil12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: v1.9.0 upgrade script fixes #1677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions script/releases/v1.9.0-slashing-ux/3-upgradeProtocolRegistry.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,10 @@ contract UpgradeProtocolRegistry is DeployProtocolRegistryImpl {
}

function testScript() public virtual override {
if (
!Env.isCoreProtocolDeployed()
|| (_areProxiesDeployed()
&& Env.getProxyAdminBySlot(address(Env.proxy.protocolRegistry())) == Env.proxyAdmin())
) {
if (!Env.isCoreProtocolDeployed()) {
return;
}

// 1. Deploy the Protocol Registry Proxy
// If proxies are not deployed, deploy them
if (!_areProxiesDeployed()) {
Expand All @@ -42,6 +39,12 @@ contract UpgradeProtocolRegistry is DeployProtocolRegistryImpl {
_addContractsToEnv();
}

// If the proxy has been upgraded already, return
if (_areProxiesDeployed() && Env.getProxyAdminBySlot(address(Env.proxy.protocolRegistry())) == Env.proxyAdmin())
{
return;
}

// 2. Deploy the Protocol Registry Implementation
_mode = OperationalMode.EOA; // Set to EOA mode so we can deploy the impls in the EOA script
DeployProtocolRegistryImpl._runAsEOA();
Expand Down
Loading