Fix issue where IPBlock and NamespaceSelector are mutually exclusive #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On upgrade, the IPBlock was already set and then after upgrade it enters
the conditional where it tries to add the NamespaceSelector. So, in that
case both are set. Instead, when we set one, we should unset the other
to ensure they aren't both set.
This fixes the error:
NetworkPolicy.networking.k8s.io "miq-application-allow-inbound-httpd" is
invalid: spec.ingress[0].from[0]: Forbidden: may not specify both ipBlock
and another peer
CP4AIOPS-22012
Fryguy
force-pushed
the
fix_http_policy
branch
from
e28fb60 to
76bdbc2
Compare
jrafanie
approved these changes
Nov 19, 2025
Member
jrafanie
left a comment
jrafanie
left a comment
There was a problem hiding this comment.
LGTM. Ye old "you can't have both" error.
Member
Author
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Nov 19, 2025
Fix issue where IPBlock and NamespaceSelector are mutually exclusive (cherry picked from commit fd3a70a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On upgrade, the IPBlock was already set and then after upgrade it enters the conditional where it tries to add the NamespaceSelector. So, in that case both are set. Instead, when we set one, we should unset the other to ensure they aren't both set.
This fixes the error:
CP4AIOPS-22012
@kschanrtp Please review.