hoist mz_now to module level #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jasonhernandez
force-pushed
the
feat/add-Materialize-backend
branch
from
0dd4aff to
3caf447
Compare
jasonhernandez
force-pushed
the
mz_now
branch
from
ed72668 to
c1f19f1
Compare
jasonhernandez
merged commit c1f19f1
into
feat/add-Materialize-backend
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to pull mz_now() out of the backend. It doesn't actually need a dependency on self and I'm going to follow up with some other functions that fit well in an api module.
Description of changes
Issues closed