Initial lgalloc support #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
force-pushed
the
add-lgalloc-support
branch
from
9755eab to
c6ab54e
Compare
jubrad
reviewed
Apr 30, 2025
README.md
Outdated
| | Name | Description | Type | Default | Required | | ||
| |------|-------------|------|---------|:--------:| | ||
| | <a name="input_aks_config"></a> [aks\_config](#input\_aks\_config) | AKS cluster configuration | <pre>object({<br/> vm_size = string<br/> disk_size_gb = number<br/> min_nodes = number<br/> max_nodes = number<br/> })</pre> | <pre>{<br/> "disk_size_gb": 100,<br/> "max_nodes": 5,<br/> "min_nodes": 1,<br/> "vm_size": "Standard_E8ps_v6"<br/>}</pre> | no | | ||
| | <a name="input_aks_config"></a> [aks\_config](#input\_aks\_config) | AKS cluster configuration | <pre>object({<br/> vm_size = string<br/> disk_size_gb = number<br/> min_nodes = number<br/> max_nodes = number<br/> })</pre> | <pre>{<br/> "disk_size_gb": 100,<br/> "max_nodes": 5,<br/> "min_nodes": 1,<br/> "vm_size": "Standard_L8s_v3"<br/>}</pre> | no | |
Contributor
There was a problem hiding this comment.
jubrad
reviewed
Apr 30, 2025
Comment on lines
+86
to
+87
| # Taints can not be removed: https://github.com/Azure/AKS/issues/2934 | ||
| # node_taints = var.enable_disk_setup ? ["materialize.cloud/disk-unconfigured=true:NoSchedule"] : [] |
jubrad
reviewed
Apr 30, 2025
Contributor
jubrad
left a comment
jubrad
left a comment
There was a problem hiding this comment.
quick review, looks good not sure about the instance type though
Contributor
alex-hunt-materialize
left a comment
alex-hunt-materialize
left a comment
There was a problem hiding this comment.
This generally looks good.
alex-hunt-materialize
approved these changes
May 6, 2025
kay-kim
reviewed
May 6, 2025
README.md
Outdated
| aks_config = { | ||
| node_count = 2 | ||
| vm_size = "Standard_L8s_v3" |
Contributor
There was a problem hiding this comment.
Should we change this to one of the Epdsv6-series ?
Collaborator
Author
There was a problem hiding this comment.
Ah yes! Good catch!
kay-kim
reviewed
May 6, 2025
README.md
Outdated
|
|
||
| | VM Size | vCPUs | Memory | Ephemeral Disk | Disk-to-RAM Ratio | | ||
| | -------------------- | ----- | ------- | -------------- | ----------------- | | ||
| | Standard\\_E2pds\\_v6 | 2 | 16 GiB | 75 GiB | \~4.7:1 | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: MaterializeInc/ephemeral-storage-setup-image#17