-
Notifications
You must be signed in to change notification settings - Fork 1
Add release generation GH workflow #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
def-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We absolutely should!
jubrad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, one comment
.github/workflows/release.yaml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Create Release | ||
| uses: release-drafter/release-drafter@v6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I live in constant fear of GHA supply chain attacks. We should make sure we review this action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should lock a specific image digest instead of the tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pinned this to b1476f6e6eb133afa41ed8589daba6dc69b4d3f5 from the tag here: https://github.com/release-drafter/release-drafter/releases/tag/v6.1.0
Adding a GHA to automatically create a release whenever we push a new tag. The GHA will also generate the release notes based on the PRs merged similar to the GH UI release notes generation button.
We could do the same for all of the other TF module repos.