-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Updates for trace methods #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
m4sterbunny
wants to merge
7
commits into
MetaMask:main
Choose a base branch
from
m4sterbunny:2473-trace-handling-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−28
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4719852
starts updates for trace methods
m4sterbunny 96c1bda
Merge branch 'main' into 2473-trace-handling-updates
m4sterbunny 88572df
createMethod confirmed with test, table hierachy improved to reflect …
m4sterbunny 1e6c032
Merge branch 'main' into 2473-trace-handling-updates
m4sterbunny c13f29b
Update services/reference/ethereum/json-rpc-methods/trace-methods/ind…
m4sterbunny 184cc6a
Update services/reference/ethereum/json-rpc-methods/trace-methods/ind…
m4sterbunny b2d6e4b
responds to review
m4sterbunny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
services/reference/_partials/trace-methods/_trace_filter-description.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| import CreditCost from '@site/src/components/CreditCost/CreditCostPrice.js'; | ||
|
|
||
| Returns traces matching the specified filter. The response is limited to 10000 traces per response. <CreditCost network="evm_trace" method="trace_filter" /> | ||
| Returns traces matching the specified filter. The block range is limited to 100 blocks per query (the difference between `fromBlock` and `toBlock`). <CreditCost network="evm_trace" method="trace_filter" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the previous note might be more accurate than the table. For
trace_block,trace_transaction, andtrace_filter, there are no "diagnostic options," the methods just always return trace information.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting, note that I am reverting fully so that includes "When tracing transactions, the trace diagnostic options are
traceandstateDiff."If diagnostic options per the original is wrong, do you have alt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my new comment below.