Skip to content

Changed Windows image to windows-2022 #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Changed Windows image to windows-2022 #2048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06006f4
Changed Windows image to `windows-2022`
fredericsimard Aug 22, 2025
7f3afa9
Set windows image to `windows-2022`
fredericsimard Aug 22, 2025
9f64049
Set Windows image to `windows-2022`
fredericsimard Aug 22, 2025
a93ef9c
Remove two workflows from acceptance test
fredericsimard Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/acceptance_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ on:
- 'web/**'
- '.github/workflows/web_**.yml'
- '.github/workflows/stg_web_**.yml'
- '.github/workflows/test_pack_doc.yml'
- '.github/workflows/package_installers.yml'
types: [ opened, synchronize, reopened, ready_for_review ]
concurrency:
group: ${{ github.head_ref }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/package_installers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
# Adding fail-fast: false so at least some artifacts gets uploaded if others fail
fail-fast: false
matrix:
os: [ macos-latest, windows-latest, ubuntu-latest ]
os: [ macos-latest, windows-2022, ubuntu-latest ]
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:
filename=${{ matrix.os }}.zip
pushd app/pkg/build/jpackage
# The windows runner does not have zip, but has 7zip.
if [ "${{ matrix.os }}" == "windows-latest" ]; then
if [ "${{ matrix.os }}" == "windows-2022" ]; then
7z a -tzip $filename *.msi
else
# Normally there should be either .deb or (.pkg and .dmg) Just capture all.
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test_pack_doc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
matrix:
java_version: [ '17' ]
os: [ ubuntu-latest, windows-latest ]
os: [ ubuntu-latest, windows-2022 ]
steps:
- uses: actions/checkout@v3
- name: Set up JDK ${{ matrix.java_version }}
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
strategy:
matrix:
java_version: [ '17' ]
os: [ ubuntu-latest, windows-latest ]
os: [ ubuntu-latest, windows-2022 ]
steps:
- uses: actions/checkout@v3
- name: Set up JDK ${{ matrix.java_version }}
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
strategy:
matrix:
java_version: [ '17' ]
os: [ ubuntu-latest, windows-latest ]
os: [ ubuntu-latest, windows-2022 ]
steps:
- uses: actions/checkout@v3
- name: Set up JDK ${{ matrix.java_version }}
Expand All @@ -103,4 +103,4 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: Documentation - javadoc - Java ${{ matrix.java_version }} - ${{ matrix.os }}
path: build/docs/javadoc/
path: build/docs/javadoc/
Loading