light-clients: fix api pagination and error codes #24206
+1,329
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alex-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
alex-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
alex-mysten
force-pushed
the
steka-aes-api-fixes
branch
from
bb958b8 to
4da355c
Compare
alex-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
alex-mysten
force-pushed
the
steka-aes-api-fixes
branch
from
4da355c to
69c5e86
Compare
alex-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
reviewed
Nov 12, 2025
| req.stream_id = Some(stream_id.to_string()); | ||
| req.start_checkpoint = Some(start_checkpoint); | ||
| req.page_size = page_size; | ||
| req.page_token = page_token.clone(); |
Contributor
There was a problem hiding this comment.
no need to fix in this PR but this is screaming out for a builder pattern
Contributor
Author
There was a problem hiding this comment.
This is prost (protobuf) generated object. We use #[non_exhaustive] which means that we don't provide constructors in rust for these objects, because adding new fields would break callers. There isn't a directive that generates builders, and my aim is to be consistent with sui-rust-sdk.
mystenmark
reviewed
Nov 12, 2025
|
|
||
| assert!( | ||
| !response.events.is_empty(), | ||
| "should have at least one event" |
Contributor
There was a problem hiding this comment.
shouldn't this be exactly 1?
mystenmark
approved these changes
Nov 12, 2025
Contributor
mystenmark
left a comment
mystenmark
left a comment
There was a problem hiding this comment.
approved with small comments
alex-mysten
force-pushed
the
steka-aes-event-indexing-fix
branch
3 times, most recently
from
9a15fa9 to
82f372c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When implementing light-client, I discovered small server-side issues to address:
Test plan
E2e tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.