Skip to content

Initial fuzzing support, and failing fuzz test case. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ximon18 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Initial fuzzing support, and failing fuzz test case. #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47226f7
Initial fuzzing support, and failing fuzz test case.
ximon18 Nov 14, 2024
aec136e
Remove accidentally committed fuzz log files.
ximon18 Nov 14, 2024
f65bf72
Switch to `main` branch of `domain` now that fuzzing support has been…
ximon18 Nov 14, 2024
e5f1888
Merge branch 'main' into fuzzing-poc
tertsdiepraam Apr 15, 2025
5d39023
Merge branch 'main' into fuzzing-poc
ximon18 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ name = "ldns"
path = "src/bin/ldns.rs"

[features]
arbitrary = [ "dep:arbitrary", "domain/arbitrary" ]
default = ["openssl", "ring"]

# Cryptographic backends
openssl = ["domain/openssl"]
ring = ["domain/ring"]

[dependencies]
arbitrary = { version = "1", optional = true, features = ["derive"] }
bytes = "1.8.0"
chrono = "0.4.38"
clap = { version = "4.3.4", features = ["cargo", "derive"] }
Expand All @@ -34,6 +36,7 @@ domain = { git = "https://github.com/NLnetLabs/domain.git", branch = "main", fea
"tsig",
"unstable-client-transport",
"unstable-sign",
"unstable-stelline",
Copy link
Contributor

@tertsdiepraam tertsdiepraam May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ximon18 this is the "controversial" change. If you agree with this then its fine with me to merge it.

Copy link
Member Author

@ximon18 ximon18 May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

The fuzz binary uses FakeEnv which causes this problem.

Could another way be to impl Env for FuzzEnv where FuzzEnv doesn't use Stelline (and so wouldn't be suitable for running dnst update or dnst notify unless some non-Stelline based impl of Env::dgram() and Env::stub_resolver_from_confg() would be possible)?

Copy link
Member

@Philip-NLnetLabs Philip-NLnetLabs May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should do ldns-testns. If so then we will get stelline as well.

Copy link
Member Author

@ximon18 ximon18 May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to #56?

Copy link
Member

@Philip-NLnetLabs Philip-NLnetLabs May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We may need to rethink the name and design for the dnst version. But it seems a useful feature.

Copy link
Member Author

@ximon18 ximon18 May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea... :-)

"unstable-validator",
"zonefile",
] }
Expand All @@ -49,6 +52,6 @@ _unused_lazy_static = { package = "lazy_static", version = "1.0.2" }
test_bin = "0.4.0"
tempfile = "3.14.0"
regex = "1.11.1"
domain = { git = "https://github.com/NLnetLabs/domain.git", branch = "main", features = [
"unstable-stelline",
] }

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] }
4 changes: 4 additions & 0 deletions fuzz/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
target
corpus
artifacts
coverage
Loading
Loading