Overhaul feature flags for DNSSEC / crypto #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'ring' and 'openssl' now enable a shared 'unstable-crypto-backend' feature, which is used internally to test whether a common backend is available. - Examples / doc tests in 'crypto', relying on 'crypto::common', have been moved to the submodule to avoid needing more 'cfg' magic. - 'unstable-crypto' now enables 'std'; this requirement was previously undetected (and the CI will be adjusted to try to catch more of these over time), but compilation would fail without it. - 'unstable-sign' and 'unstable-validator' now fail to compile if 'ring' and/or 'openssl' are not enabled. Previously, those modules would remain configured out. Its status as a breaking change is debatable, but in any case it only affects unstable features.
Contributor
Author
|
This should also fix the CI failure in #547. |
Member
|
Can we rename it to 'internal-crypto-backend' or any other convention to show that something is not to be used? |
Member
|
I think having a separate prefix for internal features would indeed be good. I don’t think we need a separate prefix for internal unstable features, though, given that they not user-facing, anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ringandopensslnow enable a sharedunstable-crypto-backendfeature, which is used internally to test whether a common backend is available.Examples / doc tests in
crypto, relying oncrypto::common, have been moved to the submodule to avoid needing morecfgmagic.unstable-cryptonow enablesstd; this requirement was previously undetected (and the CI will be adjusted to try to catch more of these over time), but compilation would fail without it.unstable-signandunstable-validatornow fail to compile ifringand/oropensslare not enabled. Previously, those modules would remain configured out. Its status as a breaking change is debatable, but in any case it only affects unstable features.