Add VFIO Validation for vgpu-device-manager #1877
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunAr7112
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
JunAr7112
force-pushed
the
vfio_changes
branch
from
5b9600e to
4b9f067
Compare
tariq1890
reviewed
Nov 10, 2025
cmd/nvidia-validator/main.go
Outdated
| return fmt.Errorf("error checking for GPU devices on the host: %w", err) | ||
| } | ||
| for _, device := range GPUDevices { | ||
| if device.SriovInfo.PhysicalFunction == nil { |
Contributor
There was a problem hiding this comment.
Suggested change
| if device.SriovInfo.PhysicalFunction == nil { | |
| if device.SriovInfo == nil || device.SriovInfo.PhysicalFunction == nil { |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this would work as device.SriovInfo is a struct value (with type SriovInfo) and not a pointer, so it cannot be nil.
cmd/nvidia-validator/main.go
Outdated
| totalVF := int(device.SriovInfo.PhysicalFunction.TotalVFs) | ||
| if totalVF > 0 { | ||
| log.Infof("Found GPU device with SR-IOV VFs: %s (TotalVFs: %d)", device.Address, totalVF) | ||
| return nil |
Contributor
There was a problem hiding this comment.
Why are we returning early here?
Contributor
Author
There was a problem hiding this comment.
If VFIO is enabled, than we wouldn't need to execute the rest of the function (and we would error by default when looking for mdev devices). That's why we would return early if VF exist. if VFIO is not enabled, there would be devices under mdevBusPath := "/sys/class/mdev_bus" and we would not enter into this for loop. Instead we would follow the earlier verification code.
JunAr7112
force-pushed
the
vfio_changes
branch
from
4b9f067 to
9be6269
Compare
JunAr7112
force-pushed
the
vfio_changes
branch
from
9be6269 to
9fd7799
Compare
Signed-off-by: Arjun <[email protected]>
JunAr7112
force-pushed
the
vfio_changes
branch
from
9fd7799 to
bc1d2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.