Default to strict decoding of OCI runtime spec #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
strict-oci-spec
branch
from
a59f077 to
01f3d1b
Compare
Instead of loading the full OCI spec when extracting the container root from the container state, this change ensures that only the Root is unmarshalled. Signed-off-by: Evan Lezar <[email protected]>
This change defaults to strict decoding of the OCI runtime spec to avoid dropping unknown fields when making OCI runtime modifications. We also add an allow-unknown-oci-spec-fields feature flag that can be used to opt-out of this behaviour. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
strict-oci-spec
branch
from
01f3d1b to
1bea5f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change defaults to strict decoding of the OCI
runtime spec to avoid dropping unknown fields when making
OCI runtime modifications.
We also add an allow-unknown-oci-spec-fields feature flag
that can be used to opt-out of this behaviour.