Add var_indices for mpolys
#2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoongNoonien
force-pushed
the
var_indices
branch
from
9458ad9 to
5498282
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2217 +/- ##
==========================================
- Coverage 87.99% 87.98% -0.01%
==========================================
Files 127 127
Lines 31802 31805 +3
==========================================
+ Hits 27983 27985 +2
- Misses 3819 3820 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lgoettgens
approved these changes
Nov 20, 2025
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
LGTM. I think it would also make sense to have this function for universal polys, could you add that in a follow-up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2214 this adds a function to obtain the indices of the variables actually occurring in a given multivariate polynomial.