Skip to content

Conversation

@joschmitt
Copy link
Collaborator

I realized that I used @inferred wrong in the tests for #2196. Because of this, the tests didn't notice that exponent_vectors(Vector{UInt}, f) did not return Vector{UInt}s.

Use `@inferred` correctly and fix return type
@joschmitt joschmitt added bugfix This change fixes an existing bug release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Nov 20, 2025
@joschmitt
Copy link
Collaborator Author

Yay, this is breaking now. It requires signatures exponent_vector(::Type{Vector{Int}}, ::MPoly, ::Int).
Is that fine? Or should I add some (temporary?) fallback to src/MPoly.jl?

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.99%. Comparing base (4c01fa1) to head (2409e84).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2221   +/-   ##
=======================================
  Coverage   87.98%   87.99%           
=======================================
  Files         127      127           
  Lines       31805    31807    +2     
=======================================
+ Hits        27985    27987    +2     
  Misses       3820     3820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma
Copy link
Member

thofma commented Nov 20, 2025

I would vote for the temporary fallback, but don't have a strong opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking bugfix This change fixes an existing bug release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants