Changes to improve performance #154
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #150.
Changes implemented so far:
ODEProblemlocal instead of globalThings I have tried:
forward.jlfunctions. Since ReverseDiff uses TrackedArrays and values it just breaks everything. The abstract types are the most specific thing I managed to narrow down.EnzymeVJP(): this gave an ugly error which was not super straightforward to debug. Once we gain more experience with ODINN we can try to tackle this.@facusapienza21 the benchmark has failed. In local it seems to work, so I'm not sure what failed.
We can work on this iteratively.