-
Notifications
You must be signed in to change notification settings - Fork 2
EQS-487: Add Cloud Build configuration for linting and rename existing YAML files #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VirajP1002
wants to merge
20
commits into
main
Choose a base branch
from
EQS-487-cir-pipelines-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petechd
reviewed
Nov 20, 2025
| @@ -0,0 +1,10 @@ | |||
| steps: | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add the "test" part here too?
Contributor
|
We need to add a link to the new MegaLinter dependency/call in the "CIMS Proxy Service - GitHub Repository" doc in "CIR Migration Service" directory. And poetry if we add testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR involves updating the current pipelines to adopt appropriate naming conventions and adding in a Cloud Build configuration for linting (and testing which will be added in the future).
Note: We may need to discuss the possibility of using a prebuilt image for Megalinter as this will make linting a quicker task as an image needs to be retrieved to run Megalinter via Docker. Moreover, this could have an impact on the time the trigger runs for when testing is added.
What has changed
As a result, we needed to update the names for the Cloud Build YAML files which will be used in the Cloud Build triggers and we added in the Cloud Build configuration to support linting using Megalinter.
How to test?
Note: Expect linting to fail until the PR to upgrade fastAPI and Starlette has been merged