Skip to content

Conversation

@VirajP1002
Copy link

@VirajP1002 VirajP1002 commented Nov 3, 2025

Motivation and Context

This PR involves updating the current pipelines to adopt appropriate naming conventions and adding in a Cloud Build configuration for linting (and testing which will be added in the future).

Note: We may need to discuss the possibility of using a prebuilt image for Megalinter as this will make linting a quicker task as an image needs to be retrieved to run Megalinter via Docker. Moreover, this could have an impact on the time the trigger runs for when testing is added.

What has changed

As a result, we needed to update the names for the Cloud Build YAML files which will be used in the Cloud Build triggers and we added in the Cloud Build configuration to support linting using Megalinter.

How to test?

  • Check the new linting configuration is correct and the new names are appropriate
  • After creating a dev environment using the changes in the cir-migration-terraform repo, run all 3 triggers against this branch:
    • cir-proxy-service-lint-and-test
    • cir-proxy-service-build-push-deploy
    • cir-proxy-service-build-on-pr

Note: Expect linting to fail until the PR to upgrade fastAPI and Starlette has been merged

@VirajP1002 VirajP1002 changed the title Rename cloud build yaml files and add file for configuration for linting EQS-487: Add Cloud Build configuration for linting and Rename existing yaml files in Proxy Service Nov 5, 2025
@VirajP1002 VirajP1002 changed the title EQS-487: Add Cloud Build configuration for linting and Rename existing yaml files in Proxy Service EQS-487: Add Cloud Build configuration for linting and rename existing yaml files in Proxy Service Nov 5, 2025
@VirajP1002 VirajP1002 changed the title EQS-487: Add Cloud Build configuration for linting and rename existing yaml files in Proxy Service EQS-487: Add Cloud Build configuration for linting and rename existing YAML files Nov 5, 2025
@VirajP1002 VirajP1002 marked this pull request as ready for review November 5, 2025 16:39
@VirajP1002 VirajP1002 requested review from a team as code owners November 5, 2025 16:39
@@ -0,0 +1,10 @@
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the "test" part here too?

@petechd
Copy link
Contributor

petechd commented Nov 20, 2025

We need to add a link to the new MegaLinter dependency/call in the "CIMS Proxy Service - GitHub Repository" doc in "CIR Migration Service" directory. And poetry if we add testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants